Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross compile to scala 3.5.x #978

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Cross compile to scala 3.5.x #978

merged 3 commits into from
Sep 17, 2024

Conversation

geirolz
Copy link
Collaborator

@geirolz geirolz commented Sep 6, 2024

No description provided.

@geirolz geirolz self-assigned this Sep 13, 2024
@geirolz geirolz requested a review from matejcerny September 17, 2024 09:38
@geirolz geirolz added this to the 5.3.0 milestone Sep 17, 2024
Copy link
Collaborator

@matejcerny matejcerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any advantages? Just curious...

@geirolz
Copy link
Collaborator Author

geirolz commented Sep 17, 2024

Are there any advantages? Just curious...

Just checking compatibility with 3.5.x and potentially use 3.5.x features ( in a dedicated package )
Moving towards to scala 3 in general

@geirolz geirolz merged commit 7569e93 into master Sep 17, 2024
3 checks passed
@geirolz geirolz deleted the support-scala-3-5 branch September 17, 2024 12:31
@matejcerny
Copy link
Collaborator

matejcerny commented Oct 29, 2024

Are there any advantages? Just curious...

Just checking compatibility with 3.5.x and potentially use 3.5.x features ( in a dedicated package ) Moving towards to scala 3 in general

@geirolz What will be the next step in general? Will we keep the 3.5.2 or replace it with the 3.6.2?

@geirolz
Copy link
Collaborator Author

geirolz commented Oct 29, 2024

I would cross compile all major and minor since it is almost cost free for this kind of library.
Moreover I'd drop 2.12 in order to just support 2.13 and all 3.x from now on.

Ideally we have to drop the oldest version when is no more commonly used, this also depends on how easy it is to migrate 3.x minors I'd say ( for the community I mean ).

I think we cannot define a strict rule now, let's see how Scala evolves and how difficult It becomes to maintain this library supporting multiple versions.

What do you think @matejcerny ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants